[PATCH] D32772: Update llvm-readobj to re-use parsing code

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 17:40:03 PDT 2017


rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/StringTable.h:39
 
-  StringRef getString(uint32_t Offset) const;
+  Expected<StringRef> getString(uint32_t Offset) const;
+
----------------
I went back and forth on this change, but I think it's a good idea. It's consistent with the way we did `consumeObject` etc.


https://reviews.llvm.org/D32772





More information about the llvm-commits mailing list