[PATCH] D32771: Verify that no compile units share the same line table in "llvm-dwarfdump --verify"

[Adrian Prantl via Phabricator via llvm-commits]

aprantl requested changes to this revision.
aprantl added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:298
   
 class Verifier {
   raw_ostream &OS;
----------------
I think it starts to make sense to create a lib/DebugInfo/DWARF/DWARFVerifier.cpp file.



================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:487
+          }
+          StmtListToDie[LineTableOffset] = CUDie;
         }
----------------
The check is fine, but this function is starting to get really long and hard to follow, especially with all the continues. Could you break it up into smaller bool verifyXXX() or visitXXX() helpers?


https://reviews.llvm.org/D32771