[PATCH] D32765: Add line table verification to lldb-dwarfdump --verify. AbandonedPublic

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 15:51:52 PDT 2017


clayborg added a comment.

Paul: I will submit a follow up patch for the DW_AT_stmt_list not being found multiple times since this patch is accepted.



================
Comment at: unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp:1671
+  raw_svector_ostream Strm(Str);
+  EXPECT_FALSE(DwarfContext.verify(Strm, DIDT_All));
+  EXPECT_TRUE(Str.str().contains(Error));
----------------
It shouldn't be const because it can cause all compile units to be parsed, all DIEs in each CU to be parsed, any number of DWARFXXX classes to be created. 


https://reviews.llvm.org/D32765





More information about the llvm-commits mailing list