[PATCH] D32354: [ELF] - Set DF_STATIC_TLS flag for i386 target.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 15:47:18 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:842
 static void scanRelocs(InputSectionBase &Sec, ArrayRef<RelTy> Rels) {
-  OffsetGetter GetOffset(Sec);
+  scanTlsModel<ELFT>(Sec, Rels);
 
----------------
This is not beautiful. Since setting DF_STATIC_TLS is not actually that important, I don't want to mess the code up for that feature. What if you add it to `getRelExpr`? That is also ugly, but it might be acceptable.


https://reviews.llvm.org/D32354





More information about the llvm-commits mailing list