[PATCH] D31642: [CodeGen] Add a 'NoAAResultsWrapperPass', and use it in SDAG/2Addr.

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 15:47:24 PDT 2017


ab added a comment.

In https://reviews.llvm.org/D31642#724540, @chandlerc wrote:

> After looking at the uses of AA in both passes here, I think I like the alternative idea of making AA optional directly in the passes. Then, for the old PM, we can use something like getAnalysisIfAvailable and just not mark the analysis as required when not optimizing codegen. What do you think? Would it be helpful if I hack up a patch?


Yeah, that was my original attempt: I sent https://reviews.llvm.org/D32766.

I very slightly prefer hiding the fact that the pass is optional, but both approaches seem reasonable.  Thanks for the help!


https://reviews.llvm.org/D31642





More information about the llvm-commits mailing list