[PATCH] D32721: Accept archive files with no symbol table instad of warning on them.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/ELF/Driver.cpp:195
+      for (MemoryBufferRef MB : getArchiveMembers(MBRef))
+        Files.push_back(make<LazyObjectFile>(MB));
+      return;
----------------
rafael wrote:
> Please warn if we add any files in here. That means that the archive really should have had a symbol table.
I guess it could also mean that the archive contains only members that do not define any symbols, which I suppose is possible in practice (e.g. each member was compiled from platform-specific code that targets some other platform -- I think Chromium does this sort of thing, for example). We should probably warn only if the LazyObjectFile adds at least one LazyObject symbol.


https://reviews.llvm.org/D32721