[PATCH] D32750: [ELF] - Added testcase gdb-index-ranges.s

[Rafael Avila de Espindola via llvm-commits]

LGTM


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> grimar created this revision.
> Herald added a subscriber: aprantl.
>
> Before https://reviews.llvm.org/rL301170 was landed, LLD did not produce correct entries in .gdb_index address area.
> Issue was fixed on LLVM DWARF parsers size and was relative to how .debug_ranges
> section was scanned. It was main problem of PR32319 I think.
>
> At the same time I think it makes sense to have testcase on LLD size too.
> This checks that we generate proper values now, because we do not have any tests for .gdb_index 
> which works with .debug_ranges atm.
>
>
> https://reviews.llvm.org/D32750
>
> Files:
>   test/ELF/gdb-index-ranges.s
>
>
> Index: test/ELF/gdb-index-ranges.s
> ===================================================================
> --- test/ELF/gdb-index-ranges.s
> +++ test/ELF/gdb-index-ranges.s
> @@ -0,0 +1,66 @@
> +# REQUIRES: x86
> +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
> +# RUN: ld.lld --gdb-index -e main %t.o -o %t
> +# RUN: llvm-dwarfdump -debug-dump=gdb_index %t | FileCheck %s
> +
> +# CHECK:       .gnu_index contents:
> +# CHECK:        Address area offset = 0x28, has 2 entries:
> +# CHECK-NEXT:     Low/High address = [0x201000, 0x201001) (Size: 0x1), CU id = 0
> +# CHECK-NEXT:     Low/High address = [0x201001, 0x201003) (Size: 0x2), CU id = 0
> +
> +.section .text.foo1,"ax", at progbits
> +.Lfunc_begin0:
> + nop
> +.Lfunc_end0:
> +
> +.section .text.foo2,"ax", at progbits
> +.Lfunc_begin1:
> + nop
> + nop
> +.Lfunc_end1:
> +
> +.section .debug_abbrev,"", at progbits
> +.byte 1                       # Abbreviation Code
> +.byte 17                      # DW_TAG_compile_unit
> +.byte 0                       # DW_CHILDREN_no
> +.byte 37                      # DW_AT_producer
> +.byte 14                      # DW_FORM_strp
> +.byte 19                      # DW_AT_language
> +.byte 5                       # DW_FORM_data2
> +.byte 3                       # DW_AT_name
> +.byte 14                      # DW_FORM_strp
> +.byte 16                      # DW_AT_stmt_list
> +.byte 23                      # DW_FORM_sec_offset
> +.byte 27                      # DW_AT_comp_dir
> +.byte 14                      # DW_FORM_strp
> +.byte 17                      # DW_AT_low_pc
> +.byte 1                       # DW_FORM_addr
> +.byte 85                      # DW_AT_ranges
> +.byte 23                      # DW_FORM_sec_offset
> +.byte 0                       # EOM(1)
> +.byte 0                       # EOM(2)
> +.byte 0                       # EOM(3)
> +
> +.section .debug_info,"", at progbits
> +.Lcu_begin0:
> +.long 38                      # Length of Unit
> +.short 4                      # DWARF version number
> +.long .debug_abbrev           # Offset Into Abbrev. Section
> +.byte 8                       # Address Size (in bytes)
> +.byte 1                       # Abbrev [1] 0xb:0x1f DW_TAG_compile_unit
> +.long 0                       # DW_AT_producer
> +.short 4                      # DW_AT_language
> +.long 0                       # DW_AT_name
> +.long 0                       # DW_AT_stmt_list
> +.long 0                       # DW_AT_comp_dir
> +.quad 0                       # DW_AT_low_pc
> +.long .Ldebug_ranges0         # DW_AT_ranges
> +
> +.section .debug_ranges,"", at progbits
> +.Ldebug_ranges0:
> +.quad .Lfunc_begin0
> +.quad .Lfunc_end0
> +.quad .Lfunc_begin1
> +.quad .Lfunc_end1
> +.quad 0
> +.quad 0
>
>
> Index: test/ELF/gdb-index-ranges.s
> ===================================================================
> --- test/ELF/gdb-index-ranges.s
> +++ test/ELF/gdb-index-ranges.s
> @@ -0,0 +1,66 @@
> +# REQUIRES: x86
> +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
> +# RUN: ld.lld --gdb-index -e main %t.o -o %t
> +# RUN: llvm-dwarfdump -debug-dump=gdb_index %t | FileCheck %s
> +
> +# CHECK:       .gnu_index contents:
> +# CHECK:        Address area offset = 0x28, has 2 entries:
> +# CHECK-NEXT:     Low/High address = [0x201000, 0x201001) (Size: 0x1), CU id = 0
> +# CHECK-NEXT:     Low/High address = [0x201001, 0x201003) (Size: 0x2), CU id = 0
> +
> +.section .text.foo1,"ax", at progbits
> +.Lfunc_begin0:
> + nop
> +.Lfunc_end0:
> +
> +.section .text.foo2,"ax", at progbits
> +.Lfunc_begin1:
> + nop
> + nop
> +.Lfunc_end1:
> +
> +.section .debug_abbrev,"", at progbits
> +.byte 1                       # Abbreviation Code
> +.byte 17                      # DW_TAG_compile_unit
> +.byte 0                       # DW_CHILDREN_no
> +.byte 37                      # DW_AT_producer
> +.byte 14                      # DW_FORM_strp
> +.byte 19                      # DW_AT_language
> +.byte 5                       # DW_FORM_data2
> +.byte 3                       # DW_AT_name
> +.byte 14                      # DW_FORM_strp
> +.byte 16                      # DW_AT_stmt_list
> +.byte 23                      # DW_FORM_sec_offset
> +.byte 27                      # DW_AT_comp_dir
> +.byte 14                      # DW_FORM_strp
> +.byte 17                      # DW_AT_low_pc
> +.byte 1                       # DW_FORM_addr
> +.byte 85                      # DW_AT_ranges
> +.byte 23                      # DW_FORM_sec_offset
> +.byte 0                       # EOM(1)
> +.byte 0                       # EOM(2)
> +.byte 0                       # EOM(3)
> +
> +.section .debug_info,"", at progbits
> +.Lcu_begin0:
> +.long 38                      # Length of Unit
> +.short 4                      # DWARF version number
> +.long .debug_abbrev           # Offset Into Abbrev. Section
> +.byte 8                       # Address Size (in bytes)
> +.byte 1                       # Abbrev [1] 0xb:0x1f DW_TAG_compile_unit
> +.long 0                       # DW_AT_producer
> +.short 4                      # DW_AT_language
> +.long 0                       # DW_AT_name
> +.long 0                       # DW_AT_stmt_list
> +.long 0                       # DW_AT_comp_dir
> +.quad 0                       # DW_AT_low_pc
> +.long .Ldebug_ranges0         # DW_AT_ranges
> +
> +.section .debug_ranges,"", at progbits
> +.Ldebug_ranges0:
> +.quad .Lfunc_begin0
> +.quad .Lfunc_end0
> +.quad .Lfunc_begin1
> +.quad .Lfunc_end1
> +.quad 0
> +.quad 0