[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lib/Object/DEFParser.cpp:57-58
+
+static BumpPtrAllocator BAlloc;
+static StringSaver Saver{BAlloc};
+
----------------
martell wrote:
> ruiu wrote:
> > Remove.
> How would you suggest I allocate the StringRef when decorating `E.Name` and `E.ExtName`?
Maybe just by making `E.Name` and `E.ExtName` be std::string instead of StringRef?


Repository:
  rL LLVM

https://reviews.llvm.org/D32689