[PATCH] D32728: Make DWARFDebugLine use StringRef for dir/file tables. NFC

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 17:57:49 PDT 2017


probinson created this revision.

From a @dblaikie review comment in https://reviews.llvm.org/D32713.
I wasn't sure whether changing the actual tables was the idea, or just simplifying the extraction.
A StringRef does take up more space, and it's common to have large numbers of directory and file entries; I don't think it's *that* big a deal, but I thought I'd get an opinion from reviewers first.


https://reviews.llvm.org/D32728

Files:
  include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  include/llvm/Support/DataExtractor.h
  lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  lib/Support/DataExtractor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32728.97374.patch
Type: text/x-patch
Size: 4886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170502/1e62bc35/attachment.bin>


More information about the llvm-commits mailing list