[PATCH] D32716: Write CodeView file checksum and line information to PDB

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp:76
 
+uint32_t DbiModuleDescriptorBuilder::calculateC13DebugInfoSize() const {
+  uint32_t Result = 0;
----------------
inglorion wrote:
> zturner wrote:
> > inglorion wrote:
> > > We're calling this method from both finalize() and finalizeMsfLayout(). Can we avoid having to call it twice?
> > Unfortunately no, at least not with the way the classes are currently designed.    It's been something I've been thinking about for a while but I don't have a good solution yet.
> I'm ok getting the existing code in as a first cut and thinking about improving it later. Can you add a TODO so that we have something we can easily grep for?
Sure.  FWIW all of the builder classes follow the same pattern, so currently this is somewhat prevalent.


https://reviews.llvm.org/D32716