[PATCH] D32517: [ubsan] Fall back to the fast unwinder when print_stacktrace=1

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/ubsan/ubsan_diag.cc:37
+  uptr bottom = 0;
+  const bool request_fast_unwind = false;
+  if (StackTrace::WillUseFastUnwind(request_fast_unwind))
----------------
use common_flags()->fast_unwind_on_fatal here


================
Comment at: test/ubsan/TestCases/Misc/missing_return.cpp:9
+// CHECK-FreeBSD-STACKTRACE: #0 {{.*}}f(void){{.*}}missing_return.cpp:[[@LINE-2]]
+// CHECK-Darwin-STACKTRACE: #0 {{.*}}f(){{.*}}missing_return.cpp:[[@LINE-3]]
 }
----------------
This is unnecessarily complex.  Remove () and (void), we don't really care about the exact function signature.


https://reviews.llvm.org/D32517