[PATCH] D32707: lldb-dwarfdump -verify [-quiet]

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

LGTM but I think Adrian should have a chance at it, as he had many comments on the previous iteration.



================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:289
+  bool success = true;
+  if (DumpType == DIDT_All || DumpType == DIDT_Info) {
+    OS << "Verifying .debug_info...\n";
----------------
clayborg wrote:
> probinson wrote:
> > I know this is the idiom used everywhere else, but here instead of the 'if' guarding a call or a just a few lines, it's guarding essentially the entire method.  I'd rather see this inverted to an early exit here, and reduce indentation in the rest of the method.
> I am breaking my change up into many piece more to come. This if should remain for now since the a future patch will need this to be here. 
ok but will probably want to be broken up into easier-to-digest pieces later then.


https://reviews.llvm.org/D32707