[PATCH] D32058: Add a section about simplifying .mir tests

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 13:39:19 PDT 2017


> On May 1, 2017, at 11:25 AM, Matthias Braun via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> MatzeB added inline comments.
> 
> 
> ================
> Comment at: llvm/trunk/docs/MIRLangRef.rst:120
> +  contains dummy functions (see above). The .mir loader will create the
> +  IR functions automatically in this case.
> +
> ----------------
> qcolombet wrote:
>> MatzeB wrote:
>>> qcolombet wrote:
>>>> Isn't that true only if you have one function. I think I saw it failed when having more than one. (We should fix that of course, if that's still the case!)
>>> It definitely works with multiple functions. I think the logic just doesn't kick in if no IR block exists in the file.
>> Oh, that could be it. So we at least need to put an empty IR section, right?
>> So we at least need to put an empty IR section, right?
> 
> No, that's the point in todays strange behavior: As soon as you have an (even empty) IR section you need to create the dummy functions manually.

Got it. 

> 
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D32058
> 
> 
> 



More information about the llvm-commits mailing list