[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 12:28:02 PDT 2017


martell updated this revision to Diff 97329.
martell added a subscriber: rafael.
martell added a comment.

moved defparser to `Object` as requested by @rafael 
comments are on email but not on phab.

change library to use `Expected<T>` as requested by @ruiu 
made `==` operator a friend and added `!=` as requested by @dberris

removed global variables as suggested by @mehdi_amini.
I already intended to remove the global variables for the fatal and warn function.
Let me know if the current version doesn't satisfy your requirement.


Repository:
  rL LLVM

https://reviews.llvm.org/D32689

Files:
  include/llvm/Object/COFFImportFile.h
  include/llvm/Object/DEFParser.h
  lib/Object/CMakeLists.txt
  lib/Object/COFFImportFile.cpp
  lib/Object/DEFParser.cpp
  tools/lld/COFF/CMakeLists.txt
  tools/lld/COFF/Chunks.cpp
  tools/lld/COFF/Config.h
  tools/lld/COFF/DLL.cpp
  tools/lld/COFF/Driver.cpp
  tools/lld/COFF/Driver.h
  tools/lld/COFF/DriverUtils.cpp
  tools/lld/COFF/LTO.cpp
  tools/lld/COFF/Librarian.cpp
  tools/lld/COFF/ModuleDef.cpp
  tools/lld/COFF/SymbolTable.cpp
  tools/lld/COFF/Symbols.h
  tools/lld/COFF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32689.97329.patch
Type: text/x-patch
Size: 85473 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170501/a9ba122b/attachment.bin>


More information about the llvm-commits mailing list