[PATCH] D31787: [TLI] Add declarations for various math header file routines from math-finite.h that create '__<func>_finite as functions

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

Can you add tests for these changes?  I think the attribute.ll and no-proto.ll tests in test/Transforms/InferFunctionAttrs would be the right place to add these.  I'm not sure if the existing tests check all of the LibFunc calls or just a representative sample.



================
Comment at: include/llvm/Analysis/TargetLibraryInfo.def:165
+/// double __acos_finite(double x);
+TLI_DEFINE_ENUM_INTERNAL(acos_finite)
+TLI_DEFINE_STRING_INTERNAL("__acos_finite")
----------------
Is there a reason for these being inserted where they are?  It looks rather arbitrary.


https://reviews.llvm.org/D31787