[PATCH] D32618: DWARF: Implementation of v5 string offsets table (.debug_str_offsets[.dwo] section)

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp marked 8 inline comments as done.
wolfgangp added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:80
+      CUNode(Node), Asm(A), DD(DW), DU(DWU), IndexTyDie(nullptr),
+      StringOffsetsStartSym(nullptr) {}
 
----------------
aprantl wrote:
> = nullptr?
This symbol is not needed in v4 and earlier and only gets created when there is a string offsets section. Could you elaborate what your objection is?


https://reviews.llvm.org/D32618