[PATCH] D32705: [compiler-rt] move tsan's Android __get_tls() to sanitizer_common

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 11:00:58 PDT 2017


cryptoad created this revision.
Herald added subscribers: arichardson, dberris, srhines, rengolin, aemerson.

TSan's Android `__get_tls()` and `TLS_SLOT_TSAN` can be used by other sanitizers as well (see https://reviews.llvm.org/D32649), this change moves them to sanitizer_common.
I picked sanitizer_linux.h as their new home.
In the process, add the 32-bit versions for ARM, i386 & MIPS.

Can the address of `__get_tls()[TLS_SLOT_TSAN]` change in between the calls?
I am not sure if there is a need to repeat the construct as opposed to using a variable. So I left things as they were.

Testing on my side was restricted to a successful cross-compilation.


https://reviews.llvm.org/D32705

Files:
  lib/sanitizer_common/sanitizer_linux.h
  lib/tsan/rtl/tsan_platform_linux.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32705.97308.patch
Type: text/x-patch
Size: 4278 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170501/c7a7c623/attachment.bin>


More information about the llvm-commits mailing list