[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

Martell Malone via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 08:19:45 PDT 2017


>
> The yaml parser is used by tools that don't link with Object. All the
> tools you listed use Object, no?

Yes that is correct, they would all use Object because of needing
`COFFImportFile`
to write an archive.
Have you suggestions on file name and location within Object?

On Mon, May 1, 2017 at 4:16 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Martell Malone <martellmalone at gmail.com> writes:
>
> >>
> >> Why do you need this in support? It could be in Object, no?
> >
> > I wasn't sure where exactly this should live until Jrmuizel suggested it
> > should live in Support.
> > See here https://reviews.llvm.org/D29892
> > I believe it makes sense because the YAML Parser lives there also.
> >
> > The def parser will be used by llvm-lib and llvm-dlltool and lld.
> > I wanted to update it in the future to give better parsing errors like
> the
> > YAML Parser does.
> > Having them live together should help with readability.
>
> The yaml parser is used by tools that don't link with Object. All the
> tools you listed use Object, no?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170501/15e6454a/attachment.html>


More information about the llvm-commits mailing list