[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Martell Malone via llvm-commits]

>
> Why do you need this in support? It could be in Object, no?

I wasn't sure where exactly this should live until Jrmuizel suggested it
should live in Support.
See here https://reviews.llvm.org/D29892
I believe it makes sense because the YAML Parser lives there also.

The def parser will be used by llvm-lib and llvm-dlltool and lld.
I wanted to update it in the future to give better parsing errors like the
YAML Parser does.
Having them live together should help with readability.

If you have a strong Objection to this I can move it to Object also.

On Mon, May 1, 2017 at 2:36 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

>
> Martell Malone via Phabricator via llvm-commits
> <llvm-commits at lists.llvm.org> writes:
>
> > martell created this revision.
> > Herald added a subscriber: mgorny.
> >
> > Repository:
> >   rL LLVM
> >
> > https://reviews.llvm.org/D32689
> >
> > Files:
> >   include/llvm/Object/COFFImportFile.h
> >   include/llvm/Support/DEFParser.h
> >   lib/Object/CMakeLists.txt
> >   lib/Object/COFFImportFile.cpp
> >   lib/Support/CMakeLists.txt
> >   lib/Support/DEFParser.cpp
>
> Why do you need this in support? It could be in Object, no?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170501/dc1ed51f/attachment.html>