[PATCH] D32681: [builtins] Enabled emulated TLS on WOA.

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 06:51:45 PDT 2017


martell added a comment.

In https://reviews.llvm.org/D32681#741979, @compnerd wrote:

> Doing this on just the MinGW build seems reasonable.  Most of the library shouldn't be needed for Windows.


Mingw headers do not follow the uppercase naming conventions of the windows sdk.
Projects that are typically build from not windows platforms follow the mingw convention when supporting both msvc and mingw.
Example https://github.com/videolan/vlc/blob/master/modules/video_output/win32/common.c#L38

The reason foe me changing to lowercase is that the MSVC is case insensitive on windows so it should not affect the target.
The only downside to using lowercase `W` is someone would be restricted if they tried to use the MSVC SDK from a non windows machine that is case sensitive.


Repository:
  rL LLVM

https://reviews.llvm.org/D32681





More information about the llvm-commits mailing list