[PATCH] D32693: [XRay] Create an Index of sleds per function

[Dean Michael Berris via Phabricator via llvm-commits]

dberris created this revision.
Herald added subscribers: rengolin, aemerson.
Herald added a reviewer: javed.absar.

This change adds a new section to the xray-instrumented binary that
stores an index into ranges of the instrumentation map, where sleds
associated with the same function can be accessed as an array. At
runtime, we can get access to this index by function ID offset allowing
for selective patching and unpatching by function ID.

Each entry in this new section (xray_fn_idx) will include two pointers
indicating the start and one past the end of the sleds associated with
the same function. These entries will be 16 bytes long on x86 and
aarch64. On arm, we align to 16 bytes anyway so the runtime has to take
that into consideration.

__{start,stop}_xray_fn_idx will be the symbols that the runtime will
look for when we implement the selective patching/unpatching by function
id APIs. Because XRay synthesizes the function id's in a monotonically
increasing manner at runtime now, implementations (and users) can use
this table to look up the sleds associated with a specific function.
This is useful in implementations that want to do things like:

- Implement coverage mode for functions by patching everything pre-main, then as functions are encountered, the installed handler can unpatch the function that's been encountered after recording that it's been called.
- Do "learning mode", so that the implementation can figure out some statistical information about function calls by function id for a time being, and then determine which functions are worth uninstrumenting at runtime.
- Do "selective instrumentation" where an implementation can specifically instrument only certain function id's at runtime (either based on some external data, or through some other heuristics) instead of patching all the instrumented functions at runtime.


https://reviews.llvm.org/D32693

Files:
  include/llvm/CodeGen/AsmPrinter.h
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  test/CodeGen/AArch64/xray-attribute-instrumentation.ll
  test/CodeGen/AArch64/xray-tail-call-sled.ll
  test/CodeGen/ARM/xray-armv6-attribute-instrumentation.ll
  test/CodeGen/ARM/xray-armv7-attribute-instrumentation.ll
  test/CodeGen/X86/xray-attribute-instrumentation.ll
  test/CodeGen/X86/xray-tail-call-sled.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32693.97262.patch
Type: text/x-patch
Size: 11013 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170501/76c9df2b/attachment.bin>