[PATCH] D32608: SROA: Use correct address space when splitting loads (PR26154)

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 30 19:17:21 PDT 2017


chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

This test case should be cleaned up and merged into `SROA/address-spaces.ll`. Also, if I delete the 'getPointerAddressSpace()` call on line 3701, no test fails, so we clearly need better tests for the address space manipulation code in this file, or the call on line 3701 is actually dead and it should be *replaced* with the load-based address space in this patch.


https://reviews.llvm.org/D32608





More information about the llvm-commits mailing list