[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Martell Malone via Phabricator via llvm-commits]

martell added a subscriber: ruiu.
martell added a comment.

I just added some notes on where I need feedback.
Thanks for taking the time to look at this @ruiu



================
Comment at: include/llvm/Support/DEFParser.h:34
+
+void parseModuleDefs(MemoryBufferRef MB, COFFShortLibrary *CSL);
+
----------------
naming changes and suggestions welcome here


================
Comment at: lib/Support/DEFParser.cpp:37
+#include "llvm/Support/raw_ostream.h"
+
+StringRef Argv0;
----------------
What will we do about the lld style warn and error messages?


================
Comment at: tools/lld/COFF/Driver.cpp:435
+
+static COFFShortLibrary createShortLibFromConfig(bool exports) {
+    COFFShortLibrary outputShortLib;
----------------
I wanted to be as un intrusive to `Config.h` and the COFF linker as possible for the first draft so there is duplication of `ImageBase` through `MinorOSVersion`.
I can change everything in the COFF folder to expect these in `Config->Info` if that works better.


Repository:
  rL LLVM

https://reviews.llvm.org/D32689