[PATCH] D28975: [LV] Introducing VPlan to model the vectorized code and drive its transformation

[Ayal Zaks via Phabricator via llvm-commits]

Ayal marked an inline comment as done.
Ayal added a comment.

In https://reviews.llvm.org/D28975#739893, @rengolin wrote:

> So, I think the document is so good and can be very helpful in further communications, that I think it should be committed separately.
>
> Once we all agree that the document explains what we really want (I mostly do), we can look at the transformations.
>
> I mean, this is a big change and we want to get it right, so minimising the patch size and intrusiveness is a plus. About half of this patch is the document. :)
>
> Makes sense?
> --renato


Yes, thanks. We're refining this document to contain only the general design of VPlan; the rest of the documentation may better suits a review-summary / commit-message of the first introductory patch.



================
Comment at: docs/VectorizationPlan.rst:10
+
+- be a *lightweight* NFC patch;
+- show key aspects of VPlan's Hierarchical CFG concept;
----------------
rengolin wrote:
> I'll echo @mkuper here: drop the NFC.
> 
> Also, this is a document that will outlive the patch, so it should also not mention the patch at all.
> 
> If we want a document to help us design or explain the VPlan, then we need a VPlan document, not a document for a patch.
> 
> Don't get me wrong, not many people write documents, especially not for patches, so this is awesome!
> 
> But we need to think about its lifetime and format.
OK, you're right. We're refining this document to contain only the general design of VPlan. The parts that specifically concern the first introductory patch will be taken out to form the SUMMARY and commit-message of this first patch, to be uploaded for review shortly.

The document was originally written with everything together to make it self-contained and hopefully easier to review.


https://reviews.llvm.org/D28975