[PATCH] D32681: [builtins] Enabled emulated TLS on WOA.

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 30 07:00:18 PDT 2017


martell created this revision.
Herald added a subscriber: mgorny.

Thanks to recent work from @marsupial here https://reviews.llvm.org/rL301350
We can now bootstrap mingw x86 and x64 with clang without importing winpthreads headers. .i.e `pthread.h`

I never enabled emutls on WOA because of this extra step previously.
@mstorsjo would enabling this cause any issues with your work?

I also changed `Windows.h` to `windows.h` to support mingw from file case sensitive systems.
MSVC doesn't care much about this because it is run from windows.

I added Saleem also because he cares about cross compiling to windows and can give another perspective on the case sensitivity.


Repository:
  rL LLVM

https://reviews.llvm.org/D32681

Files:
  lib/builtins/CMakeLists.txt
  lib/builtins/emutls.c


Index: lib/builtins/emutls.c
===================================================================
--- lib/builtins/emutls.c
+++ lib/builtins/emutls.c
@@ -98,7 +98,7 @@
 
 #else
 
-#include <Windows.h>
+#include <windows.h>
 #include <malloc.h>
 #include <stdio.h>
 #include <assert.h>
Index: lib/builtins/CMakeLists.txt
===================================================================
--- lib/builtins/CMakeLists.txt
+++ lib/builtins/CMakeLists.txt
@@ -390,7 +390,8 @@
       udivmoddi4.c
       udivmodsi4.c
       udivsi3.c
-      umoddi3.c)
+      umoddi3.c
+      emutls.c)
 elseif(NOT WIN32)
   # TODO the EABI sources should only be added to EABI targets
   set(arm_SOURCES


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32681.97229.patch
Type: text/x-patch
Size: 682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170430/82111049/attachment.bin>


More information about the llvm-commits mailing list