[PATCH] D32674: [LoopIdiom] PR32811 check for safety while expanding

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 29 19:39:33 PDT 2017


Yes, just make the isSafeToExpand an assert and bugpoint it, and it should
give you something much smaller.


On Sat, Apr 29, 2017 at 7:26 PM, Davide Italiano via Phabricator <
reviews at reviews.llvm.org> wrote:

> davide added inline comments.
>
>
> ================
> Comment at: test/Transforms/LoopIdiom/unsafe.ll:1-7
> +; RUN: opt -S < %s -loop-idiom | FileCheck %s
> +; CHECK-NOT: memset
> +; check that memset is not generated (for assignment in for.body5)
> because that will result
> +; in udiv hoisted out of the loop by the SCEV Expander
> +; TODO: ideally we should be able to generate memset
> +; if SCEV expander is taught to generate the dependencies
> +; at the right point.
> ----------------
> I'm under the impression this test can be greatly reduced.
>
>
> https://reviews.llvm.org/D32674
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170429/8b9872b6/attachment.html>


More information about the llvm-commits mailing list