[polly] r301670 - [Codegen] Disable Polly's codegen verification by default

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 12:15:28 PDT 2017


Author: grosser
Date: Fri Apr 28 14:15:28 2017
New Revision: 301670

URL: http://llvm.org/viewvc/llvm-project?rev=301670&view=rev
Log:
[Codegen] Disable Polly's codegen verification by default

As has been reported in the previous commit, codegen verification can result in
quadratic compile time increases for large functions with many scops. This is
certainly not something we would like to have in the Polly default
configuration. Hence, we disable codegen verification by default -- also to see
if this resolves some of the compilation timeouts we currently see on the AOSP
buildbots. We still leave this feature in Polly as it has shown _very_ useful
for debugging. In fact, we may want to have a discussion if we can bring this
feature back in a way that does not impact compilation time so much.

Thanks to Eli Friedman <efriedma at codeaurora.org> for reporting this issue and
for providing the test case in the previous commit (where I forgot to
acknowledge him).

Modified:
    polly/trunk/lib/CodeGen/CodeGeneration.cpp

Modified: polly/trunk/lib/CodeGen/CodeGeneration.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/CodeGeneration.cpp?rev=301670&r1=301669&r2=301670&view=diff
==============================================================================
--- polly/trunk/lib/CodeGen/CodeGeneration.cpp (original)
+++ polly/trunk/lib/CodeGen/CodeGeneration.cpp Fri Apr 28 14:15:28 2017
@@ -43,7 +43,7 @@ using namespace llvm;
 
 static cl::opt<bool> Verify("polly-codegen-verify",
                             cl::desc("Verify the function generated by Polly"),
-                            cl::Hidden, cl::init(true), cl::ZeroOrMore,
+                            cl::Hidden, cl::init(false), cl::ZeroOrMore,
                             cl::cat(PollyCategory));
 
 static cl::opt<bool>




More information about the llvm-commits mailing list