[PATCH] D20116: Add speculatable function attribute

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In https://reviews.llvm.org/D20116#741087, @hfinkel wrote:

> In https://reviews.llvm.org/D20116#740922, @arsenm wrote:
>
> > Only allow for intrinsics
>
>
> Why only for intrinsics? I thought we had concluded that we'd only allow it for declarations and not on call sites (which may technically mean on call sited but only matching the declaration). I think it is important that we can apply it to regular functions.


I think so too, but @sanjoy said to restrict it to intrinsics for now. Intrinsics are the important part. I also ran into one minor issue with the call site restriction in https://reviews.llvm.org/D32655 where speculatable intrinsic calls are sometimes replaced with non-speculatable libcalls.


https://reviews.llvm.org/D20116