[PATCH] D32645: AMDGPU: GFX9 GS and HS shaders always have the scratch wave offset in SGPR5

Marek Olšák via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 11:34:07 PDT 2017


mareko added inline comments.


================
Comment at: test/CodeGen/AMDGPU/scratch-simple.ll:5-7
+; This used to fail due to a v_add_i32 instruction with an illegal immediate
+; operand that was created during Local Stack Slot Allocation. Test case derived
+; from https://bugs.freedesktop.org/show_bug.cgi?id=96602
----------------
arsenm wrote:
> Copy paste from local-stack-slot-bug.ll.
> 
> It would probably be better to merge the two tests rathe than having the exact same function repeated in multiple files. 
No. This patch renames local-stack-slot-bug.ll to scratch-simple.ll and adds new tests.


https://reviews.llvm.org/D32645





More information about the llvm-commits mailing list