[PATCH] D32615: [pdb, lld] Write CodeView line tables to PDB.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 10:22:43 PDT 2017


ruiu added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:550-551
 enum LineFlags : uint16_t {
-  HaveColumns = 1, // CV_LINES_HAVE_COLUMNS
+  kLineFlagsNone = 0,
+  kLineFlagsHaveColumns = 1, // CV_LINES_HAVE_COLUMNS
 };
----------------
Is `k` prefix hangarian?


================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/ModuleDebugStream.h:64
+
+class ModuleDebugStream {};
 }
----------------
What is this for?


https://reviews.llvm.org/D32615





More information about the llvm-commits mailing list