[PATCH] D32620: [DAGCombiner] shrink/widen a vselect to match its condition operand size (PR14657)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 09:20:05 PDT 2017


spatel updated this revision to Diff 97110.
spatel marked an inline comment as done.
spatel added a comment.

Patch updated:

1. Bail out if we require LegalOperations (unlikely that this could have benefits if we are past legalization).
2. That change tilted the scale to make this a proper DAGCombiner member rather than a static, so some cosmetic diffs from that.
3. Improved code comments, structure, variable names, and assert message (no functional change from any of these either).


https://reviews.llvm.org/D32620

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/X86/cast-vsel.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32620.97110.patch
Type: text/x-patch
Size: 18518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170428/7d85e779/attachment.bin>


More information about the llvm-commits mailing list