[PATCH] D32631: Speed up the -Map option.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/MapFile.cpp:50
+  // Maps sections to their symbols.
+  DenseMap<const SectionBase *, std::vector<SymbolBody *>> Symbols;
+
----------------
dberris wrote:
> ruiu wrote:
> > dberris wrote:
> > > No `SmallVector<...>` ?
> > Does it make any noticeable difference? I usually use data structures in the standard library unless that is not appropriate because most people are more familiar with std::* than llvm:*.
> I suspect it should, especially if you size the SmallVector with enough values to not require an additional indirection when reaching for the values. It should be easy to measure, given that you already have a test case. :)
OK, let me do that tomorrow.


https://reviews.llvm.org/D32631