[PATCH] D32621: TargetLowering: Add finalizeLowering() function; NFC

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:595
 
-  if (TLI->hasCopyImplyingStackAdjustment(MF))
-    MFI.setHasCopyImplyingStackAdjustment(true);
-
-  // Freeze the set of reserved registers now that MachineFrameInfo has been
-  // set up. All the information required by getReservedRegs() should be
-  // available now.
-  MRI.freezeReservedRegs(*MF);
+  TLI->finalizeLowering(*MF);
 
----------------
MatzeB wrote:
> arsenm wrote:
> > Can we move this to after ExpandISelPseudos at least? It's a problem that reserved registers are frozen this early
> I think that should work, we certainly could try. Maybe rename `ExpandISelPseudos` to `FinalizeISel` then?
> 
> However I'd like to do that in a separate patch then, to avoid complications when backporting this to a production branches.
Last time I tried to do that a few PPC tests broke, although that might have been fixed since then


Repository:
  rL LLVM

https://reviews.llvm.org/D32621