[PATCH] D31888: [LLD][ELF] Always use Script::assignAddresses()

[Peter Smith via llvm-commits]

Sure I'll take a look at it as soon as I can, my apologies for the
mistake. I'm away from the office till Tuesday, so I may not be able
make much progress until I get back. If you have a test case that you
can paste here or raise a defect then this will help.

On 28 April 2017 at 00:06, Dmitry Mikulin via Phabricator
<reviews at reviews.llvm.org> wrote:
> dmikulin added a comment.
>
> Can this review be re-opened?
> There's an inconsistency in the arg passing to fabricateDefaultCommands(). It's declared as taking "bool AllocateHeader" parameter, but called with "Config->MaxPageSize" as an argument, so AllocateHeader is pretty much always true. This creates a problem when headers are not to be allocated, as is the case on our platform. I'm still trying to figure out how to deal with it, since fixing the argument does not fix the problem: second call to allocateHeaders(), from assignAddresses() moves the starting address below MinVA.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D31888
>
>
>