[PATCH] D32614: [GVNHoist] Fix: PR32821, add check for anticipability in case of infinite loops

Aditya Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 15:05:15 PDT 2017


hiraditya added a comment.

In https://reviews.llvm.org/D32614#739947, @dberlin wrote:

> I'm at a loss to understand why you believe you need to compute joint post-dominance (which is what this is) to compute ANTIC.


If the set of BasicBlocks (WL) do not joint-post-dominate the hoisting point (HoistBB), then the expression to be hoisted (from WL) cannot be ANTIC in HoistBB.
It is a necessary condition what I'm checking here. The other check is the availability of operands in each basic block which is being checked elsewhere. Maybe the function name is not appropriate.
Please suggest your views.

Thanks,


https://reviews.llvm.org/D32614





More information about the llvm-commits mailing list