[PATCH] D32281: [ARM] ACLE Chapter 9 intrinsics

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

It would be nice to have an ARMV5TE test to make sure that the intrinsics that are supposed to work for that target actually do.



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:7795
+    Results.push_back(Res.getValue(0));
+    Results.push_back(Res.getValue(1));
+    return;
----------------
Assuming that LowerINTRINSIC_WO_CHAIN returns a value with exactly two results seems a little dubious; it might work here, but it's a landmine for anyone dealing with this code in the future.  Better to just make it a separate method which pushes onto the Results vector directly.


https://reviews.llvm.org/D32281