[PATCH] D32440: [scudo] Move thread local variables into their own files

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/scudo/scudo_allocator.cpp:209
 
-  MaybeStartBackgroudThread();
+  // TODO(kostyak): determine if MaybeStartBackgroudThread could be of some use.
 
----------------
cryptoad wrote:
> alekseyshl wrote:
> > What was the reason of removing it? This thread implements RSS checks and heap profiling, don't you want this functionality supported in Scusdo too?
> I removed it (for now) for a couple of reasons:
> - I currently do not have a `__sanitizer_print_memory_profile` function defined, so the heap profiling isn't of a much use;
> - the soft rss check uses a writeable function pointer as a callback, which is something I am generally trying to avoid in Scudo;
> 
> My plan is to have a second look once things stabilize a bit so that this function can be of use, but I figure it wasn't needed for now.
> 
> Let me know if that makes sense, or if you'd rather have it stay!
I was merely curious and you explained the reasoning, no need to bring it back. Thanks!


https://reviews.llvm.org/D32440