[PATCH] D32440: [scudo] Move thread local variables into their own files

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 10:24:54 PDT 2017


alekseyshl accepted this revision.
alekseyshl added a comment.

Other than these minor comments, LGTM.



================
Comment at: lib/scudo/scudo_allocator.cpp:209
 
-  MaybeStartBackgroudThread();
+  // TODO(kostyak): determine if MaybeStartBackgroudThread could be of some use.
 
----------------
What was the reason of removing it? This thread implements RSS checks and heap profiling, don't you want this functionality supported in Scusdo too?


https://reviews.llvm.org/D32440





More information about the llvm-commits mailing list