[PATCH] D32578: CMake: Set LLVM_MAIN_INCLUDE_DIR to LLVM_INCLUDE_DIR
Tom Stellard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 27 07:57:48 PDT 2017
tstellar added a comment.
In https://reviews.llvm.org/D32578#739094, @chapuni wrote:
> The changes themselves look good.
> But I don't understand your issue. Did you happen to any cases that llvm-config or --includedir prevents something?
If you install llvm-config to /usr/libexec/llvm/bin, then llvm-config --includedir will ignore where the include files actually are and always return /usr/libexec/llvm/include
> I think we may get rid of llvm-config there in near future. Instead, we should let CMake find LLVM as a package.
>
> Possible steps;
>
> 1. Use llvm-config just to inform --cmakedir.
> 2. Add an option to use find_package(LLVM).
> 3. Nuke llvm-config stuff. (Then, we might miss consistency of llvm-config...)
This is what I'm looking at doing. This is just one of the preliminary cleanups.
https://reviews.llvm.org/D32578
More information about the llvm-commits
mailing list