[PATCH] D32117: Update TableGen LangIntro.rst

Wei-Ren Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 06:36:14 PDT 2017


chenwj added a comment.

In https://reviews.llvm.org/D32117#736622, @asb wrote:

> Hi, thanks for the patch. My feedback is:
>
> 1. Limitations of literal formats shouldn't be discussed when introducing the types.
> 2. Perhaps outside the scope of this patch, but it does seem a little odd that a simple string literal can be assigned to either a string or code variable, but code fragment literals can't be assigned to string variables (at least on the couple of months old build on LLVM I have on this machine). The existing description that a code fragment is "just a multiline string literal" seems incorrect due to this.


I think I already addressed the item one? As for item two, how do you want to rephrase it?


https://reviews.llvm.org/D32117





More information about the llvm-commits mailing list