[PATCH] D32272: [XRay] Add Google Benchmark library + initial XRay benchmarks

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a subscriber: MatzeB.
kristof.beyls added a comment.

Could you explain the rationale for adding libs/benchmarks-1.1.0?
Also, since that seems to have a different license, you probably need to add that directory to the top-level LICENSE.TXT file as one of the sub-directories with "additional or alternate copyrights,licenses, and/or restrictions".



================
Comment at: MultiSource/Benchmarks/XRay/CMakeLists.txt:6-7
+
+set(PROG retref-bench-O0)
+list(APPEND CPPFLAGS -O0)
+llvm_multisource()
----------------
It looks weird to me that this CMakeFile explicitly set different targets for -O0, -O1, -O2, -O3. I don't think other programs in the test-suite do this.
Do you have a good reason to do it like this?
It seems to go slightly against the general philosophy of making the test-suite an as-normal-as-possible cmake project; where you would set optimization level during cmake configuration; and if you want to collect data for multiple optimization levels build the test-suite multiple times with different cmake configurations.
@MatzeB : do you have thoughts on this?


https://reviews.llvm.org/D32272