[PATCH] D32442: [Polly][CMake] Use object library to build two flavours of Polly.

Singapuram Sanjay Srivallabh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 00:14:54 PDT 2017


singam-sanjay added inline comments.


================
Comment at: lib/CMakeLists.txt:75
+# well.
+add_polly_library(Polly $<TARGET_OBJECTS:PollyCore>)
+target_link_libraries(Polly
----------------
Why can't we just add PollyCore as a dependency ?


================
Comment at: lib/CMakeLists.txt:131
+    else ()
+      target_link_libraries(Polly
+        LLVMNVPTXCodeGen
----------------
We need **all** these libraries and not just those that might be returned by `llvm_map_components_to_libnames(nvptx_libs NVPTX)` (I'm assuming that you mean nvptx_libs might turn out to be a subset of all possible NVPTX libraries).

Nevertheless, won't all LLVMNVPTX* libraries be included in nvptx_libs since they are **all** a part of the NVPTX backend ?


================
Comment at: unittests/CMakeLists.txt:12
-
-    # The Polly target does not depend on its required libraries, except:
-    # - BUILD_SHARED_LIBS=ON
----------------
`patch` failed to update this file because it couldn't find these comments. At which commit did you create the diff ?


https://reviews.llvm.org/D32442





More information about the llvm-commits mailing list