[PATCH] D32547: [CodeView] Isolate the parsing code for various types of CV debug info fragments

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 16:39:16 PDT 2017


rnk accepted this revision.
rnk added a comment.

In https://reviews.llvm.org/D32547#738775, @amccarth wrote:

> I'm satisfied, but you might want to wait to hear from at least one other reviewer.


Looks good, at a really really high level. I'd say when you get to the writing portion, try to get more feedback from Rui and Bob, since it's useful to have a linker perspective for that.


https://reviews.llvm.org/D32547





More information about the llvm-commits mailing list