[PATCH] D32352: Go to eleven

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 02:33:26 PDT 2017


avt77 updated this revision to Diff 96693.
avt77 added a comment.

**Lambdas refactoring: in fact I tried to do it from the very beginning but I got the error message:

-

/home/atischenko/workspaces/lea-mult-DAG/llvm/lib/Target/X86/X86ISelLowering.cpp: In function ‘llvm::SDValue combineMulSpecial(uint64_t, llvm::SDNode*, llvm::SelectionDAG&, llvm::EVT, llvm::SDLoc)’:
/home/atischenko/workspaces/lea-mult-DAG/llvm/lib/Target/X86/X86ISelLowering.cpp:30955:3: error: conversion from ‘combineMulSpecial(uint64_t, llvm::SDNode*, llvm::SelectionDAG&, llvm::EVT, llvm::SDLoc)::<lambda(int, int, bool)>’ to non-scalar type ‘llvm::SDValue’ requested

  };
  ^

/home/atischenko/workspaces/lea-mult-DAG/llvm/lib/Target/X86/X86ISelLowering.cpp:30973:55: error: no match for call to ‘(llvm::SDValue) (int, int, bool)’

  Result = combineMulShlAddOrSub(5, 1, /*isAdd*/true);
   

**I did not understand the reason of the message that's why I did what was done. Now, I tried with "auto"  - and it works! I still don't understand where is the problem but it works.**


https://reviews.llvm.org/D32352

Files:
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/mul-constant-i16.ll
  test/CodeGen/X86/mul-constant-i32.ll
  test/CodeGen/X86/mul-constant-i64.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32352.96693.patch
Type: text/x-patch
Size: 147041 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170426/8975ef3f/attachment-0001.bin>


More information about the llvm-commits mailing list