[PATCH] D32268: Use WeakVH instead of WeakTrackingVH in AliasSetTracker's UnkownInsts

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/Analysis/AliasSet/unknown-inst-tracking.ll:1
+; RUN: opt -S -licm -loop-unswitch < %s | FileCheck %s
+
----------------
davide wrote:
> I wish there was a way to trigger this with a single pass, but even when I reduced the testcase I wasn't able to find it.
Can you add a comment to explain what you're testing here? I would also add some more `CHECK` lines as I'm not a fan of no-crash tests, but up to you.


================
Comment at: test/Analysis/AliasSet/unknown-inst-tracking.ll:1-2
+; RUN: opt -S -licm -loop-unswitch < %s | FileCheck %s
+
+ at global = external global i32
----------------
I wish there was a way to trigger this with a single pass, but even when I reduced the testcase I wasn't able to find it.


https://reviews.llvm.org/D32268