[PATCH] D32404: [LV] Make LIT test insensitive to basic block numbering

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 10:46:45 PDT 2017


update_test_checks does this.

It actually works fine on this testcase, and generates something
insensitive to the label names, only that the right labels appear in the
same places.
(Though you may have to remove the -NEXT* if you want it to be insensitive
to generation order)


On Tue, Apr 25, 2017 at 10:42 AM, Michael Kuperstein via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> mkuper added a comment.
>
> Honestly, I don't feel strongly about this.
>
> I think the most resilient scheme would be something like matching the
> meaningful part as a part of the regexp, e.g. [[PRED_UDIV_IF1:pred.udiv.if[0-9]+]],
> [[PRED_UDIV_IF2:pred.udiv.if[0-9]+]], etc. I'm just not sure the overhead
> is worth it.
>
>
> https://reviews.llvm.org/D32404
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170425/af603ee1/attachment.html>


More information about the llvm-commits mailing list