[PATCH] D32352: Go to eleven

[Zvi Rackover via Phabricator via llvm-commits]

zvi added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:30970
                           const X86Subtarget &Subtarget) {
+  if (!MulConstantOptimization)
+    return SDValue();
----------------
avt77 wrote:
> zvi wrote:
> > avt77 wrote:
> > > zvi wrote:
> > > > This flags is intended also for vector types?
> > > I think YES. Or we need separate one?
> > Since this patch only affects scalar multiplies, i would expect the added flag to only affect the scalar multiply code path. 
> > Combines for vector types are in reduceVMULWidth which remains unchanged.
> > Does this make sense?
> Do you mean I should put this check at line 31033? Yes, you're right. I'll do it.
Yes, please.


https://reviews.llvm.org/D32352