[PATCH] D32491: [globalisel][tablegen] Compute available feature bits correctly.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 08:26:10 PDT 2017


dsanders created this revision.
Herald added subscribers: igorb, kristof.beyls.

Predicate<> now has a field to indicate how often it must be recomputed.
Currently, there are two frequencies, per-module (RecomputePerFunction==0)
and per-function (RecomputePerFunction==1). Per-function predicates are
currently recomputed more frequently than necessary since the only predicate
in this category is cheap to test. Per-module predicates are now computed in
getSubtargetImpl() while per-function predicates are computed in selectImpl().

Tablegen now manages the PredicateBitset internally. It should only be
necessary to add the required includes.

Also fixed a problem revealed by the test case where
constrainSelectedInstRegOperands() would attempt to tie operands that
BuildMI had already tied.


https://reviews.llvm.org/D32491

Files:
  include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  include/llvm/Target/Target.td
  lib/CodeGen/GlobalISel/InstructionSelector.cpp
  lib/Target/AArch64/AArch64.h
  lib/Target/AArch64/AArch64InstructionSelector.cpp
  lib/Target/AArch64/AArch64TargetMachine.cpp
  lib/Target/X86/X86.h
  lib/Target/X86/X86InstrInfo.td
  lib/Target/X86/X86InstructionSelector.cpp
  lib/Target/X86/X86TargetMachine.cpp
  test/CodeGen/X86/GlobalISel/select-inc.mir
  test/TableGen/GlobalISelEmitter.td
  utils/TableGen/GlobalISelEmitter.cpp
  utils/TableGen/SubtargetFeatureInfo.cpp
  utils/TableGen/SubtargetFeatureInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32491.96571.patch
Type: text/x-patch
Size: 28648 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170425/17a42147/attachment.bin>


More information about the llvm-commits mailing list