[PATCH] D32450: [libunwind] Add 64-bit SPARC support

Mark Kettenis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 00:07:33 PDT 2017


kettenis added inline comments.


================
Comment at: libunwind/src/DwarfInstructions.hpp:89
+    return addressSpace.getP(
+	cfa + (pint_t)savedReg.value) ^ registers.getWCookie();
+
----------------
compnerd wrote:
> Please prefer `static_cast` rather than the C-style cast as this is C++ code.
The code surrounding this uses C-style casts.  I can change those too, but that's probably best done as a separate change.


https://reviews.llvm.org/D32450





More information about the llvm-commits mailing list