[PATCH] D32025: [Polly][DeLICM] Use Known information when comparing Existing.Occupied and Proposed.Occupied.

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 21:10:28 PDT 2017


grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/Transform/DeLICM.cpp:379-380
+///
+/// Value instances that do not represent a specific value are represented by an
+/// unnamed tuple of 0 dimensions. Its meaning depends on the context. It can
+/// either mean a specific but unknown value which cannot represented by other
----------------
BE represented


================
Comment at: lib/Transform/DeLICM.cpp:684
+    // Instead of partitioning the element/lifetime intervals into a part that
+    // both Knowledges occupy (which requires an expensive subtraction) and for
+    // these check whether they are known to be the same value, we check only
----------------
these TO check


https://reviews.llvm.org/D32025





More information about the llvm-commits mailing list